gtk-builder-tool: Some refactoring
authorMatthias Clasen <mclasen@redhat.com>
Sat, 2 May 2015 18:41:02 +0000 (14:41 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Sat, 2 May 2015 21:39:05 +0000 (17:39 -0400)
Break out similar code into separate functions.

gtk/gtk-builder-tool.c

index 2b2009cd26e00e26451f9fdeb65078199d4fe0bf..b7a2a4b07ec7af0c246182cee85ab6d9a86beda0 100644 (file)
@@ -162,6 +162,34 @@ needs_explicit_setting (MyParserData *data,
   return found;
 }
 
+static void
+maybe_start_packing (MyParserData *data)
+{
+  if (data->packing)
+    {
+      if (!data->packing_started)
+        {
+          g_print ("%*s<packing>\n", data->indent, "");
+          data->indent += 2;
+          data->packing_started = TRUE;
+        }
+    }
+}
+
+static void
+maybe_start_cell_packing (MyParserData *data)
+{
+  if (data->cell_packing)
+    {
+      if (!data->cell_packing_started)
+        {
+          g_print ("%*s<cell-packing>\n", data->indent, "");
+          data->indent += 2;
+          data->cell_packing_started = TRUE;
+        }
+    }
+}
+
 static void
 maybe_start_child (MyParserData *data)
 {
@@ -213,32 +241,15 @@ maybe_emit_property (MyParserData *data)
         }
     }
 
-  if (data->packing)
-    {
-      if (!data->packing_started)
-        {
-          g_print ("%*s<packing>\n", data->indent, "");
-          data->indent += 2;
-          data->packing_started = TRUE;
-        }
-    }
-
-  if (data->cell_packing)
-    {
-      if (!data->cell_packing_started)
-        {
-          g_print ("%*s<cell-packing>\n", data->indent, "");
-          data->indent += 2;
-          data->cell_packing_started = TRUE;
-        }
-    }
+  maybe_start_packing (data);
+  maybe_start_cell_packing (data);
 
   g_print ("%*s<property", data->indent, "");
   for (i = 0; data->attribute_names[i]; i++)
     {
       if (!translatable &&
-          (strcmp (data->attributes_name[i], "comments") == 0 ||
-           strcmp (data->attributes_name[i], "context") == 0))
+          (strcmp (data->attribute_names[i], "comments") == 0 ||
+           strcmp (data->attribute_names[i], "context") == 0))
         continue;
 
       escaped = g_markup_escape_text (data->attribute_values[i], -1);